_Uglify the current member of move_iterator #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
commented
Jul 23, 2020
StephanTLavavej
requested changes
Jul 23, 2020
miscco
force-pushed
the
fix_move_iterator
branch
from
8cac1dd
to
9ebcb32
Compare
StephanTLavavej
approved these changes
Jul 23, 2020
StephanTLavavej
changed the title
|
For final review, we should think about the bincompat consequences. (I think they're acceptable, as mentioned above.) |
CaseyCarter
approved these changes
Jul 23, 2020
I don't recall CLR metadata knowing about access control at all, or caring about the names of members: it's primarily concerned with the sizes of non-static data members and their offsets within the complete object's layout. (We even had success with the |
|
Thank you for making our code, and our lives, a little |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
counted_iteratorI found thatmove_iteratorhas a non-ugly membercurrent.The same forreverse_iteratorAs this is a purely private member it is not user accessible and should be
_Ugly